nlsclientscript

Hi

I just tried version 5.0 after previously using v3.6.

I use it as in the example: $("#cont").html($.ajaxSettings.dataFilter(data.content)); . Apparently this does not work anymore ad 'dataFilter' is unknown in Chrome (for example) when using 5.0. It appears that 'dataFilter' is defined only when using 'IE'.

For those that use NLSClientScript to create jQuery interface elements: I upgraded to 5.0 to see if this would fix another issue I have. When doing $("#cont").html(...) to create a jQuery dialog, I now conclude the 'div' is moved elsewhere by jQuery.dialog which is responsible in my case of creating multiple dialogs that eventually conflict with each other... That's not a NLSClientScript issue in the end ;-) and I'll have to fix this differently.

Using version 5 seems to work as expected in IE7/8 and Chrome. I upgraded after IE7/8-issues in version 3.3.

Only thing I would like to see is proper DocBlock commenting on variables and functions in your extension.

And actually, maybe a better name because "NLSClientScript" doesn't say anthing about what it does, but something like "AjaxCompatibleClientScript" or maybe just "EClientScript" or "XClientScript" is better.

You are right. My 'static' pages register a small js script. But how you said they don't need jquery.

I register now jquery for all my sites in my main layout view.

I use the google lib and I think it is no problem for performance.

I guess that is not a static page where the issue occurs. On the pages where no script file registered, the component renders nothing. On your "static page" some script is registered requires no jquery, that's when the issue occurs.

So yes, for now all pages need jquery registered since the component uses it. I'll fix in the next release to register jquery automatically in every case.

I have install version 5.0.

It works on all my pages where jquery is included.

But on my static pages (e.g. impressum page) where I need no jquery there I get the error 'jquery undefined'.

What can I do. Must I include on all my pages jquery or can I do this with exclude pattern ?

test results about usages of the latest version are welcome

IE7 has a problem with the "src" attribute of the script tag, as can be seen in http://bugs.jquery.com/ticket/11404

So the update of the grid returns the alert "Parser error".

The solution to the problem would be to change the script to:

(...)
selector : "script:not([src=\"\"]),link[rel=\"stylesheet\"]",
(...)

is #7098 fixed in 3.6 version? I am still facing the problem in filtering in the cgridview

I have problems. When the extension is enabled the HTML content is being duplicated in ajax requests.

Detail: the problem does not occur in IE, only in Firefox and Chrome. And only occurs when the return of Ajax is the complete page, including the HTML tag.

The javascript code behaves completely different in IE vs Firefox and Chrome.

The developer needs to fix the default behavior on all browsers.

A workaround for Firefox and Chrome (but certainly not the ultimate solution):

(...)
firstTagRg : /<([a-z1-6]+)[^>]*>/i,
(...)
holders : {
    "default" : $(document.createElement("div")),
    "tr" : $(document.createElement("tbody")),
    "html" : $(document.createElement("html"))
},

hoplayann thanks for the report, i'll check and will release a new version in a few days, there's also an other issue needs to be fixed.

Hello,

I am using version 3.6 of your extension in my Yii project.

It seems that the selection of script tags in the HTML source fails for some reason in Internet Explorer 7. The looping through the SCRIPT or LINK elements is the place where we have now added an extra test case, to be sure that there is at least a not empty SRC or HREF attribute defined. (see added code below)

//fetching scripts from the DOM
                    for(i=0,res=$(document).find($._nlsc.selector); i<res.length; i++) {
                        tmp = res[i];
 
                        // CODE ADDED:
                        // ie7 sometimes gets accidental script tags and selector returns undefined objects
                        if (tmp.src == "" && typeof(tmp.href) === "undefined") {
                            continue;
                        }
 
                        ind = tmp.src ? tmp.src : tmp.href;
                        ind = ind.replace($._nlsc.urlGarbageRg,"");
                        if (tmp.href && tmp.parentNode!=$._nlsc.head)
                            $._nlsc.head.appendChild(tmp);
                        $._nlsc.resMap[ind] = 1;
                    }

And I had to add the code again in the other loop :

// iterate over new scripts and remove if source is already in DOM:
                for(i=0,res=holder.find($._nlsc.selector); i<res.length; i++) {
                    tmp = res[i];
 
                    // CODE ADDED:
                    // ie7 sometimes gets accidental script tags and selector returns undefined objects
                    if (tmp.src == "" && typeof(tmp.href) === "undefined") {
                        continue;
                    }
 
                    ind = tmp.src ? tmp.src : tmp.href;
                    ind = ind.replace($._nlsc.urlGarbageRg,"");
                    if (resMap[ind])
                        $(tmp).remove();
                    else {
                        if (tmp.href)
                            $._nlsc.head.appendChild(tmp);
                        else
                            tmp.removeAttribute("defer");
                        resMap[ind] = 1;
                    }
                }

Is it possible that the jquery selector is not precise enough ?

selector : "script[src],link[rel=\"stylesheet\"]",

Please let me know if there would be a fix for that issue in your next revision.

Yann

fixed in 3.6

Here is returning an error warning that "head" is not defined.

This piece of code:

// iterate over new scripts and remove if source is already in DOM:
for(i=0,res=holder.find($._nlsc.selector); i<res.length; i++) {
    tmp = res[i];
    ind = tmp.src ? tmp.src : tmp.href;
    ind = ind.replace($._nlsc.urlGarbageRg,"");
    if (resMap[ind])
        $(tmp).remove();
    else {
        if (tmp.href)
            head.appendChild(tmp);
        else
            tmp.removeAttribute("defer");
        resMap[ind] = 1;
    }
}

should be?

// iterate over new scripts and remove if source is already in DOM:
for(i=0,res=holder.find($._nlsc.selector); i<res.length; i++) {
    tmp = res[i];
    ind = tmp.src ? tmp.src : tmp.href;
    ind = ind.replace($._nlsc.urlGarbageRg,"");
    if (resMap[ind])
        $(tmp).remove();
    else {
        if (tmp.href)
            $._nlsc.head.appendChild(tmp);
        else
            tmp.removeAttribute("defer");
        resMap[ind] = 1;
    }
}

yep, 3.5 works like expected. thanks for your work and a happy new year!

check 3.5 and also the demo on nlacsoft.net (it does exactly your case:))

Hi,

unfortunately this new version does not fix the problem. I'm encountering this problem in chrome 15 on kubuntu and in other browsers. I've got a lot of work to do at the moment because it is the last workday for this year (yay), but i'm going to create a testcase for this problem in the new year.

Hi, i tested the bug, actually i experienced such issue only in IE (not exactly the same issue but can be related) and added a fix in 3.4. i'm curious if it has been fixed at your case

Thanks, excellent catch and solution. I'll include it in the next release, also have to fight other cases (dt,dd,li,caption,thead etc)

Hi, thanks.

"NLS" points to "NLacSoft" what is my domain name actually. (i'll release some valuable content there in a few days!:))

The "EClientScript" is a kinda standard extension name format, i use my extension with that name at the company i work for.

hi, i've switched from 2.1 to 3.3 today and found the following bug:

in a form which is organized in a table, the user can add new rows via ajax. the server is sending only a new table row (tr-element) with some columns in it.

the javascript-filter takes this row and puts it via innerHTML into a div-element which kills all tr- and td-elements from the original code. it then filters the dom and returns the broken code.

quick-fix:

insert above line 74:

data = jQuery.trim(data);
        if(data.slice(0,3) == "<tr") {
          $._holder = $(document.createElement("tbody"));
        } else {
          $._holder = $(document.createElement("div"));
        }
        $._holder[0].innerHTML = data; //<<< original line