audittrail2 Follow @yiiframework

I have opened a new toic here: http://www.yiiframework.com/forum/index.php/topic/40416-extension-audittrail-2/

You can also post an issue on github: https://github.com/Sammaye/audittrail/issues?state=open

Can you open a forum topic for this extension, or if one exist post the link?

Yeah, that is very weird.

I would try and see what getAttributes returns and if it returns fields that are not empty I would iterate through auditAttributes to see why it ditches them.

I can't see anything obvious from the classes.

@Sammaye It seems to get the old value on some models but on others nothing is stored, let me investigate, here are dropbox link to the two different models,does not work on this one Example One Works on this one Example Two . I have also tried playing with

public $skipNulls = true;

nothing much, I am using the github version

Strange indeed.

Can you post a code snippet that can replicate this behaviour?

Maybe it is how it is being used in the model as a behaviour in the parent model.

Also can you just tell me if getAttributes() actually returns anything in this case?

It might not be recording old values because those values are either '' or null, these values I omit to save database space; that option can be turned off however.

I cant seem to get Old value to be recorded, its seems this is tied to

$this->Owner->getAttributes()

Any pointers, thanks again, the allowed and ignored functionality is really awesome

I will look into that getIsNewRecord one though it does work on my system.

Ah I see, it is running the validation rules. Strange I don't see that behaviour in my system but you are right that is a bug. I have fixed it now :).

you have this in your rules for model AuditTrail array('action, model, field, stamp, model_id', 'required'),

but when you create a trail for create (there another issue here I think) or delete only pass variable $action and save fails. another thing I changed is that you use afterSave to save the trail and you use isNewRecord, I'm not sure right now cause I can't check it right away but that will always be false, because the model is already saved so you have to check that flag in beforeSave and ask latter in the afterSave.

Hope it helps sorry if I'm wrong :D

Fixed time bug.

Would be awesome if you can give an example of the Delete thing you said about :)

Strange I use delete and what not and it works fine for me. It should place "Create" (or "Delete") and the field attribute, as for the model_id: that is indeed a required attribute. Is there a reason you are using this without activeRecord since all active record models should have an id (primary key).

I shall look into that time thing. I must admit I had not tested that functionality, however $time() is not a valid variable. Can you give me an example code which causes the bugable behaviour?

Edit: I see what you meant now by $time(), lol. I will change that asap.

There are some issues with audittrails2, for example is unable to record create and delete trails because model_id and field attributes in model AuditTrail are required so save fails every time. Another bug is found in LoggableBehavior in line 101, when using variable $time() instead of function time(), by default it would not give error because the default is to not save timestamp.

thanks for your extension, very usefull to me!

Yea it is quite bad example but the alternative is a really complex PDO statement with lots of ORs which is bad. I may proposed something like:

/**
     * This function is not in use yet, the field is not applied to the general schema so don't use it
     * @example serializedSearch(array(array(1, 'User'), array(1, 'Company'), array('{"d": 1, "e": 2}', 'Other')))
     */
    function serializedSearch($serializedIds = array()){
 
        $crtieria = new CDbCriteria(array(
            'order'=>'stamp DESC',
            'with'=>array('user'),
        ));
 
        $in = array();
        foreach($serializedIds as $k => $val){
            if(isset($val[0]) && isset($val[1]))
                $in[] = json_encode(array($val[0], $v[1]));
        }
        $criteria->addInCondition('serialized_id', $in);
 
        return new CActiveDataProvider('AuditTrail', array(
            'criteria'=>$criteria,
            'pagination'=>
                array(
                'pageSize'=>100,
                )
            )
        );
    }

Anyway let's see where it goes :).

aa, ok. I did not check source codes, just slightly misunderstood 'printing out' snippet, because you are preparing there criteria with just model id's and without model names...

Indeed normally you cannot differentiate the model however this too stores the model name.

So it stores:

model_id: 1
model: Company

model_id: 1
model: User

If you check the AuditTrail model and the function getParent() within that you will see this is how I get the parent model (The line for it here: https://github.com/Sammaye/audittrail/blob/master/behaviors/LoggableBehavior.php#L98).

The field name is a little confusing and could probably do with changing. I originally made this to work on the same schema as the previous extension.

The last snippet was just an example of getting all audit logs by a specific primary key. Probably a bad one since I too realised this key confliction and have since changed the code I show here to go on the "model" field as well. I might also allow extra descriptive fields as a future addition since I realised to get a group of audit logs for a specific context you might need to know more about the subobjects of a parent. However I am unsure how this will be done atm.

When the Primary is an array it should JSON encode the primary key (https://github.com/Sammaye/audittrail/blob/master/behaviors/LoggableBehavior.php#L122), I am unsure as to whether that is the right thing to do since I personally have never had an array based primary, in Yii yet.

Hope it helps,

I did notice, that you just store primary key of model in your audit trail (looking at $criteria in last snippet). It is rather wrong, because you cannoc assign this behavior to more than one model, or its keys will collide. To be more clear:

Lets say you have two models: User, Company. Both have attached your behavior. If I change User with id=1 AuditTrail record is created with model_id=1. When I change Company with id=1 - same thing (audittrail is created with model_id=1), but both have same foreign key reference and you cannot say whoch is for User trail and witch for Company...

I did write very similiar behavior for my project, but I store both class name of model and it's primary key. In fact there are also cases when primary key is an array (multiple column primary key) and in such case your behavior will fail as well...