minifyclientscript Follow @yiiframework

I think its slowing down my site. Without this < 1 sec after this 8 sec.

Thanks, Shiv

on lines 146,198 and 202 also need ckeck on file size if equal zero byte,ignore publish those files

if(filesize($this->minifyPath . "/$filenames[$media]") > 0){
  $this->registerLinkTag("stylesheet", "text/css", Yii::app()->assetManager->getPublishedUrl($this->minifyPath) . "/$filenames[$media]", $media == "default" ? null : $media);
}
.
.
.
if ($position===self::POS_HEAD){
if(filesize($this->minifyPath . DIRECTORY_SEPARATOR . "$filenameCore.js") > 0)
  $this->registerScriptFile($publishedMinifyPath . "/$filenameCore.js", $position);
}
if(filesize($this->minifyPath . DIRECTORY_SEPARATOR . "$filename.js") > 0) {
  $this->registerScriptFile($publishedMinifyPath . "/$filename.js", $position);
}

I noticed that whenever the content of the compiled JavaScript is empty, there is still a script tag generated, causing an unnecessary http request.

This portion of d3.js:

// Compute the angular scale factor: from value to radians.
    var k = ((typeof endAngle === "function"
        ? endAngle.apply(this, arguments)
        : endAngle) - startAngle)
        / d3.sum(values);

produces the following error:

JSMin_UnterminatedRegExpException

Unterminated RegExp: '/ d3.sum(values); '

/var/www/html/mysite/pub/protected/extensions/jsmin/JSMin.php(175)

163 $this->output .= $this->a . $this->b; 164 $pattern = '/'; // in case needed for exception 165 while (true) { 166 $this->a = $this->get(); 167 $pattern .= $this->a; 168 if ($this->a === '/') { // end pattern 169 break; // while (true) 170 } elseif ($this->a === '\') { 171 $this->output .= $this->a; 172 $this->a = $this->get(); 173 $pattern .= $this->a; 174 } elseif (ord($this->a) <= self::ORD_LF) { 175 throw new JSMin_UnterminatedRegExpException( 176 'Unterminated RegExp: '. var_export($pattern, true)); 177 } 178 $this->output .= $this->a; 179 } 180 $this->b = $this->next(); 181 } 182 // end case ACTION_DELETE_A_B 183 } 184 } 185
186 protected function isRegexpLiteral() 187 {

Koduc, did you make sure to run this test in production mode? and did you also build the cache beforehand?

This extension is VERY slow with twitter bootstrap. Page loaded without extension:

ab -c10 -n500 http://localhost/index.php

Requests per second: 15.56 [#/sec] (mean)

Page loaded with extension:

Requests per second: 0.76 [#/sec] (mean)

POS_* aren't ignored anymore, and the files should no longer rebuild at every request.

huge, huge problem in the component part of this:

Lines 156-157:

$compileCoreJs = YII_DEBUG || !file_exists($publishedMinifyPath . DIRECTORY_SEPARATOR . "/$filenameCore.js");
$compileJs = YII_DEBUG || !file_exists($publishedMinifyPath . DIRECTORY_SEPARATOR . "$filename.js");

Should be:

$compileCoreJs = YII_DEBUG || !file_exists($this->minifyPath. DIRECTORY_SEPARATOR . "$filenameCore.js");
$compileJs = YII_DEBUG || !file_exists($this->minifyPath. DIRECTORY_SEPARATOR . "$filename.js");

This was causing a 2 second time to first byte on my server because it generated the cached files every request.

its says the problem in components\MinifyClientScript.php line: 132

I can't seem to reproduce your error, but you could check whether the runtime/MinifyClientScript directory has been published properly, just look for the core-BIGHASHHERE.js file in the assets directory.

Extending CAssetManager could be a nice way to minify the code, but it would require you to recursively search the directory to find .css- and .js-files and it would not merge the files though (which MinifyClientScript also does). You could try and use JSMin and CssCompressor to extend CAssetManager.

ksangers,

Thanks for your quick reply, the 404 errors are not coming through now; however, the error "jQuery is not defined" is still an issue.

I cleaned the www/assets and www/protected/runtime/MinifyClientScript directories. Also to confirm components/MinifyClientScript.php line 132 is your updated version.

Current error is:

jQuery is not defined
jquery.yiilistview.js()

After running the application again: jquery exists in the runtime/MinifyClientScript under a hash file name. Anyone know a solution, something I'm missing?

What if you extended CAssetManager.php and replaced function publish(...) to pipe any .css or .js through minify ?

Could you check components/MinifyClientScript.php line 132 (at the end of minifyCss())? It should be:

file_put_contents("$this->minifyPath/$filenames[$media]", CssCompressor::deflate($cssArray[$media]));

and not:

file_put_contents("$this->minifyPath/$filenames[$media]", CssCompressor::deflate($css));

Otherwise clearing the runtime and www/assets directories might help.

Hi!

Same as Jesse :

"NetworkError: 404 CHttpException - http://myapp.local/assets/7b768164/core-a23c688da8235c331a4a2d9edc5422a6b411e98caf8e301725933f7f5c4767b2.js"

Plus, when I take a look in the file (wich actually exists), it is empty...

Cheers!

Thanks for the comments guys! I've updated the code and put it online. Let me know what you think of this version, especially what you don't like so I can fix it! :)

Hi, great extension you've made here!

I keep receiving this error:

"Uncaught ReferenceError: jQuery is not defined | jquery.yiilistview.js:114"
"NetworkError: 404 Not Found - http://localhost/WWW/assets/e94214b1%5Cdefault-d2a448605e081d92dd6f50542f3648bcdde0a938ddef420baf0df4efbe329b52.css"
"NetworkError: 404 Not Found - http://localhost/WWW/assets/e94214b1%5C45982dae651db9bcf314be0ba414a5d0d9c7abf84c4c8d5367c16c370006b112.js"

etc

Obviously the assets are not being found. Perhaps the "%5C" is the problem??

I'm wondering if anyone else had a similar issue and knows the solution?

Just a small addition to this wonderful clientscript minimizer:

In order to make CClientScript chainable, please return the object:

public function registerScript() [ return parent::

public function registerCss() [ return parent::

(line 223/234/236)

I have updated the file to do the callback differently, could you test this? If it still does not work I would like to know what PHP version you are using so I can fix this better.

Hope this works :)

Your extensions give me this error :

"preg_replace_callback() [function.preg-replace-callback]: Requires argument 2, 'self::cssReplaceCallback', to be a valid callback"

Where is the problem here?

Ok, thx for the update...

Yeah I noticed this, and fixed this. You got the crappy version really quick! (<5mins of me posting it)

I had the strpos(haystack, needle) wrong, I've already updated it. Sorry for the inconvenience.