fileimagearbehavior Follow @yiiframework

Hi,

I'm using your extension. It's great. However, I believe its performance may be improved by storing directory file list in memory on the first access.

Consider the scenario of having a grid view with user photos. For 10 users, glob() function inside of your extension would be called for 10 times. Instead directory listing could be queried just once and then saved in memory.

Hi,

there is a warning because you don't check if $fs is null before passing it to foreach.

You should change it to this:

protected function deleteFile($path, $fname) {
        $fs = $this->getAnyExistingFilesName($path, $fname);
        if($fs) {
            foreach ($fs as $f) {
                unlink($f);
            }
        }
 
    }

Hi,

It is possible to use image watermark for "large" format?

any chance you will put that on github? or should we do that? ;-)

hi, very nice extension. Problem: I inserted this ext. to Photo model. When I create Photo item it works fine, but when I create Photo item in another model where have relation with Photo model it create item but not manipulation with file(

When I change method afterSave in FileARBehavior() to:

//$file = CUploadedFile::getInstance($this->owner, $this->attribute);
$file = CUploadedFile::getInstance(Category::model(), $this->attribute);

it work fine. But how to set model dynamically?

How to sent file to Photo model?

public function actionCreate()
    {
        $model=new Category;
        $this->performAjaxValidation($model);
 
        if(isset($_POST['Category']))
        {
            $model->attributes=$_POST['Category'];
 
            $file = CUploadedFile::getInstance($model, 'default_image');
 
            if(!is_null($file))
            {
                $image = new Photo;
 
                $image->fileimg = $file;
                $image->filename = $file->getName();
                $image->name = $file->getName();
                $image->extension = $file->getExtensionName();
                $image->byte_size = $file->getSize();
                $image->mime_type = $file->getType();
 
                if($image->save(true))
                {
                    $model->default_image = $image->getPrimaryKey();
                }
                else
                    throw new CHttpException(400, 'file not saved');
            }
 
 
 
            if(empty($_POST['Category']['parent_id']))
            {
                if ($model->saveNode())
                {
                    $this->redirect(array('view','id'=>$model->id));
                }
            }
            else
            {
                $parent_id = $this->loadModel((int)$_POST['Category']['parent_id']);
 
                if($model->appendTo($parent_id,true))
                {
 
                    $this->redirect(array('view','id'=>$model->id));
                }
 
            }
        }
 
        $this->render('create',array(
            'model'=>$model,
        ));
    }

I mode this problem so:

...
public $otherModel;
...
if (empty($this->otherModel))
    $file = CUploadedFile::getInstance($this->owner, $this->attribute);
else
    $file = CUploadedFile::getInstance($this->otherModel, $this->attribute);
...

and when I create Photo Item in other model I do that:

$file = CUploadedFile::getInstance($model, 'fileimg');
 
            if(!is_null($file))
            {
 
                $model->default_image = new Photo();
 
                $model->default_image->otherModel = Category::model();
 
                $model->default_image->filename = $file->getName();
                $model->default_image->extension = $file->getExtensionName();
                $model->default_image->byte_size = $file->getSize();
                $model->default_image->mime_type = $file->getType();
 
                if($model->default_image->save(true))
                {
                    $model->default_image = $model->default_image->getPrimaryKey();
                }
                else
                    throw new CHttpException(400, 'file not saved');
            }

If are you can made this problem with simple method please write here! )

Thank you for this nice extention. I encountered 2 little problems:

1. Uploading file with extention in capital letters (pic.JPG) does not work
   Fix: in FileARBehavior insert strtolower in line 212 strpos(strtolower($this->extension), strtolower($file->extensionName))

2. The image magick driver does not work correctly when chaining filters, like first applying resize and then crop. The problem is, that you changed the original class so that you have only one call to "convert" When preparing that single operation then the crop operation works with the original dimensions of the image rather than with the result of the initial resize. The original image magick driver class calls image magick "convert" for every image operation. This might take longer but works correctly.
   Fix: user original Kohona class, only applying minor changes to fit Yii

Please note that you should add quotes around the call to convert, so that it will also work if the path ($this->dir) has spaces in it, like this
if ($error = exec('"'.escapeshellcmd($this->dir.'convert'.$this->ext).'" '.$dir.' '.$this->cmd_image.' '.$this->cmd_image))

is it anyway for us to upload multiple files / images for 1 model.?

Component treats 'jpg' and 'JPG' differently.

I'm getting: Property "ImageARBehavior.useImageMagick" is not defined.

Btw, please use GitHub for development.... :)

Hello,

Very nice extention. I am heving some problems though with the create. Update works fine but wnen i create a new item I get and error when the field is required.

New version with new things:

• 3 new functions for image processing
• formats and processing can be applied to FileARBehavior
• FileARBehavior and ImageARBehavior don't need to be in components folder
• ...

See the changelog, and look at the example file !

Tell me what you think, report bugs and so on;

Thank you intel352 for all your ideas !

I love them all ;

I just created a repository on sourceforge so it is now possible to post issues/feature requests.

If you want, you can help me by sending me your code (I will send you a private message soon). Then I will make a new version 0.7 with the new things and mention your nickname in sources.

Tanks again

Nice job on this extension. Few questions & requests for you:

1. Do you have this code stored in a project repository so we can report issues/feature requests?
2. I installed your ext into a subfolder of my extensions directory, and encountered various errors as you've hard-coded the path to your other includes. I recommend you instead use a custom path alias (i.e.: fileImageAr) that we then define in main.php, so then we can store the extension wherever we want without issue.
3. You mentioned that Paperclip exists, and is similar to your own extension. If you'll notice, it also somehow supports variables anywhere in the path string. That would be a good feature to have, so that we can (for instance) specify a path with the model PK as a subfolder in the path. I needed this functionality immediately, so implemented a workaround in my model using afterSave and afterConstruct to add model variables to the web root path.
4. It would be great if you added an is_dir() check prior to saving the file, and if not exists, attempt to create the dir (with recursive set to true). That would match up with my previous request (variables in file path). I've done this in my own copy, but it's always nice to see such features adopted in the core.

Works perfect.Very useful,I wanted a picture field for an Article class,and didn't want/was bored to mess up with the database...Thanks!

It is now possible to get the file(s) path(s), in order to test if a file exist or to delete it when you want.

In fact the name is generated by the primary key, or by the concatenation of keys separated by '_' in case of multiple primary keys. I'm not sure that a random generator is needed, because it is unique if you specify prefix and suffix correctly (or if you save into different directories).

But maybe you're right and can convince me ; we can discuss this on the dedicated forum newly created ; This way we won't annoy the followers.

Hi,

You can have a property to auto-generate the filename, example:

'recipeImgBehavior' => array( 'class' => 'ImageARBehavior', 'autoGenerateFileName' => true,

And the filename will be: /images/{prefix} + date('YmdHis') + {suffix} + {extension}

Instead of date('YmdHis') you can use another random generator.

It prevent image replace and can cause some problems if image is replaced.

Usually i use:

date('YmdHis') + '_' + {random numer 0 to 9} + {random numer 0 to 9} + {random numer 0 to 9} + {random numer 0 to 9} + {random numer 0 to 9}

And the final filename is (example):

20110101120000_01234

I'm sorry, I forgot this ! Here is the way to do this :

$format = 'large'; //get the user-defined large format (in the example you can use 'large', 'thumb' and 'normal'.
// 'normal' is the default
 
$model->recipeImgBehavior->getFileUrl($format);

It's better each day.

If you want more image processing functions, you can view here: http://www.verot.net/php_class_upload_samples.htm

I have one extesion here in Yii with this class.

This class do everything with images.

I dont understand how the get the thumb, large and normal file, can you explain more?

There is now a new version of this extension (0.5).

It is a rewrite (in parts) of the code to let the user create multiple image formats and it is now better structured and I hope without errors or bugs.

The api has changed a bit. Check the example.

I recommend you to use this new version, as the api is now right for me.

Tell me if you find some bugs, and if you enjoy it too !

In the future, I may add some processing functions for images, by adding new function in the Image class. If you do this on your own, share it and I will report it.