Need help with actionupdate

When i update my blog with blog_thumb and/or full_header file blank i got Fatal error:

Fatal error: Call to a member function saveAs() on a non-object in C:\wamp\www\content\protected\controllers\PostController.php on line 99

I modded my actionUpdate so images are optional when blog is updated so i don’t have to post same images all the time when i update post/blog, so far doesn’t work. =/

PostController.php




	public function actionCreate()

	{

		$model=new Post;

		if(isset($_POST['Post']))

		{

			$model->attributes=$_POST['Post'];

			$model->blog_thumb=CUploadedFile::getInstance($model,'blog_thumb');//added for blog thumbnail upload for Blog

			$model->full_header=CUploadedFile::getInstance($model,'full_header');//added for image upload for full header Blog

			if ($model->validate())

			if($model->save())

			    $model->blog_thumb->saveAs(Yii::app()->basePath . '/../images/thumb/' . $model->blog_thumb);//added for blog thumbnail image upload Blog

				$model->full_header->saveAs(Yii::app()->basePath . '/../images/full/' . $model->full_header);//added for image upload full header Blog

				$this->redirect(array('view','id'=>$model->id));

		}


		$this->render('create',array(

			'model'=>$model,

		));

	}

	/**

	 * Updates a particular model.

	 * If update is successful, the browser will be redirected to the 'view' page.

	 */

	public function actionUpdate()

	{

		$model=$this->loadModel();

		if(isset($_POST['Post']))

		{

			$model->attributes=$_POST['Post'];

			$blog_thumb=CUploadedFile::getInstance($model,'blog_thumb');//added for image upload for Blog

			if (is_object($blog_thumb) && get_class($blog_thumb)==='CUploadedFile')

            $model->blog_thumb = $blog_thumb;

			$full_header=CUploadedFile::getInstance($model,'full_header');//added for image upload for full header Blog

			if (is_object($full_header) && get_class($full_header)==='CUploadedFile')

            $model->full_header = $full_header;

			if (is_object($model->blog_thumb))

			if (is_object($model->full_header))

			if($model->save())

			    $model->blog_thumb->saveAs(Yii::app()->basePath . '/../images/thumb/' . $model->blog_thumb->name);//added for image upload Blog

Line:99->			$model->full_header->saveAs(Yii::app()->basePath . '/../images/full/' . $model->full_header->name);//added for image upload for full header Blog

				$this->redirect(array('view','id'=>$model->id));

		}


		$this->render('update',array(

			'model'=>$model,

		));

	}



I’m trying to do when i update post/blog to have blog-thumb and full_header optional not required,

only required when i create new post.

Thank You!!

Your line #99 will execute no matter if model is saved or not, right?

Additionally maybe you should check:




if ($model->full_header instanceof CUploadedFile){

$model->full_header->saveAs(Yii::app()->basePath . '/../images/full/' . $model->full_header->name);//added for image upload for full header Blog

}




No luck, now bypass the error but doesn’t save post after i hit save button just goes back to how it was before

“(doesn’t update/save post when i change something)”.

Hello. Have you checked in your Post table? I think you are indeed saving into the db but not the image files.

Furthermore, please check these points for both your create and your update actions:

EDIT: please disregard first point, it seems I’m wrong for saveAs requirement

  • [s]As far as I know, Yii::app()->basePath returns a web url, while saveAs needs a filepath. Check with

Yii::getPathOfAlias('webroot') . '/images/thumb/'

and


Yii::getPathOfAlias('webroot') . '/images/full/'

[/s]

  • technically you could have errors if the model doesn’t validate or save because you don’t wrap all the related lines, plus the fact you will be redirected even if you don’t save because of these errors. You need to add curled braces like this

if($model->save()) {

  $model->blog_thumb->saveAs(Yii::app()->basePath . '/../images/thumb/' . $model->blog_thumb->name);

  $model->full_header->saveAs(Yii::app()->basePath . '/../images/full/' . $model->full_header->name);

  $this->redirect(array('view','id'=>$model->id));

}

I tried it with curled braces with different ways and i didn’t get it to work yet i will try more tricks, Thank you anyways tho.

here is my post model

Post:


<?php

class Post extends CActiveRecord

{

	/**

	 * The followings are the available columns in table 'tbl_post':

	 * @var integer $id

	 * @var string $title

	 * @var string $content

	 * @var integer $status

	 * @var integer $create_time

	 * @var integer $update_time

	 * @var integer $author_id

	 */

	const STATUS_DRAFT=1;

	const STATUS_PUBLISHED=2;

	const STATUS_ARCHIVED=3;

	public $blog_thumb;//image for blog thumbnail.

	public $full_header;//image for blog full image header.

	/**

	 * Returns the static model of the specified AR class.

	 * @return CActiveRecord the static model class

	 */

	public static function model($className=__CLASS__)

	{

		return parent::model($className);

	}

	/**

	 * @return string the associated database table name

	 */

	public function tableName()

	{

		return '{{post}}';

	}

	/**

	 * @return array validation rules for model attributes.

	 */

	public function rules()

	{

		// NOTE: you should only define rules for those attributes that

		// will receive user inputs.

		return array(

			array('title, content, blog_thumb, full_header, status', 'required'),

			array('status', 'in', 'range'=>array(1,2,3)),

			array('title', 'length', 'max'=>128),

			array('blog_thumb', 'file', 'types'=>'jpg, gif, png'),//for blog thumbnail.

			array('full_header', 'file', 'types'=>'jpg, gif, png'),//for blog full image header.

			array('title, status', 'safe', 'on'=>'search'),

		);

	}

 	/**

	 * @return array relational rules.

	 */

	public function relations()

	{

		// NOTE: you may need to adjust the relation name and the related

		// class name for the relations automatically generated below.

		return array(

			'author' => array(self::BELONGS_TO, 'User', 'author_id'),

			'comments' => array(self::HAS_MANY, 'Comment', 'post_id', 'condition'=>'comments.status='.Comment::STATUS_APPROVED, 'order'=>'comments.create_time DESC'),

			'commentCount' => array(self::STAT, 'Comment', 'post_id', 'condition'=>'status='.Comment::STATUS_APPROVED),

		);

	}

	/**

	 * @return array customized attribute labels (name=>label)

	 */

	public function attributeLabels()

	{

		return array(

			'id' => 'Id',

			'title' => 'Title',

			'content' => 'Content',

			'status' => 'Status',

			'create_time' => 'Create Time',

			'update_time' => 'Update Time',

			'author_id' => 'Author',

		);

	}

	/**

	 * @return string the URL that shows the detail of the post

	 */

	public function getUrl()

	{

		return Yii::app()->createUrl('post/view', array(

			'id'=>$this->id,

			'title'=>$this->title,

		));

	}

	/**

	 * Adds a new comment to this post.

	 * This method will set status and post_id of the comment accordingly.

	 * @param Comment the comment to be added

	 * @return boolean whether the comment is saved successfully

	 */

	public function addComment($comment)

	{

		if(Yii::app()->params['commentNeedApproval'])

			$comment->status=Comment::STATUS_PENDING;

		else

			$comment->status=Comment::STATUS_APPROVED;

		$comment->post_id=$this->id;

		return $comment->save();

	}

	/**

	 * This is invoked before the record is saved.

	 * @return boolean whether the record should be saved.

	 */

	protected function beforeSave()

	{

		if(parent::beforeSave())

		{

			if($this->isNewRecord)

			{

				$this->create_time=$this->update_time=time();

				$this->author_id=Yii::app()->user->id;

			}

			else

				$this->update_time=time();

			return true;

		}

		else

			return false;

	}

	/**

	 * This is invoked after the record is saved.

	 */

	protected function afterSave()

	{

		parent::afterSave();

	}


	/**

	 * This is invoked after the record is deleted.

	 */

	protected function afterDelete()

	{

		parent::afterDelete();

		Comment::model()->deleteAll('post_id='.$this->id);

	}

	/**

	 * Retrieves the list of posts based on the current search/filter conditions.

	 * @return CActiveDataProvider the data provider that can return the needed posts.

	 */

	public function search()

	{

		$criteria=new CDbCriteria;


		$criteria->compare('title',$this->title,true);


		$criteria->compare('status',$this->status);


		return new CActiveDataProvider('Post', array(

			'criteria'=>$criteria,

			'sort'=>array(

				'defaultOrder'=>'status, update_time DESC',

			),

		));

	}

}

and my full post controller

PostController:


<?php


class PostController extends Controller

{

	public $layout='column2';


	/**

	 * @var CActiveRecord the currently loaded data model instance.

	 */

	private $_model;


	/**

	 * @return array action filters

	 */

	public function filters()

	{

		return array(

			'accessControl', // perform access control for CRUD operations

		);

	}


	/**

	 * Specifies the access control rules.

	 * This method is used by the 'accessControl' filter.

	 * @return array access control rules

	 */

	public function accessRules()

	{

		return array(

			array('allow',  // allow all users to access 'index' and 'view' actions.

				'actions'=>array('index','view'),

				'users'=>array('*'),

			),

			array('allow', // allow authenticated users to access all actions

				'users'=>array('choppa'),

			),

			array('deny',  // deny all users

				'users'=>array('*'),

			),

		);

	}


	/**

	 * Displays a particular model.

	 */

	public function actionView()

	{

		$post=$this->loadModel();

		$comment=$this->newComment($post);


		$this->render('view',array(

			'model'=>$post,

			'comment'=>$comment,

		));

	}	

	/**

	 * Creates a new model.

	 * If creation is successful, the browser will be redirected to the 'view' page.

	 */

	public function actionCreate()

	{

		$model=new Post;

		if(isset($_POST['Post']))

		{

			$model->attributes=$_POST['Post'];

			$model->blog_thumb=CUploadedFile::getInstance($model,'blog_thumb');//added for blog thumbnail upload for Blog

			$model->full_header=CUploadedFile::getInstance($model,'full_header');//added for image upload for full header Blog

			if ($model->validate())

			if($model->save())

			    $model->blog_thumb->saveAs(Yii::app()->basePath . '/../images/thumb/' . $model->blog_thumb);//added for blog thumbnail image upload Blog

				$model->full_header->saveAs(Yii::app()->basePath . '/../images/full/' . $model->full_header);//added for image upload full header Blog

				$this->redirect(array('view','id'=>$model->id));

		}


		$this->render('create',array(

			'model'=>$model,

		));

	}

	/**

	 * Updates a particular model.

	 * If update is successful, the browser will be redirected to the 'view' page.

	 */

	public function actionUpdate()

	{

		$model=$this->loadModel();

		if(isset($_POST['Post']))

		{

			$model->attributes=$_POST['Post'];

			$blog_thumb=CUploadedFile::getInstance($model,'blog_thumb');//added for image upload for Blog

			if (is_object($blog_thumb) && get_class($blog_thumb)==='CUploadedFile')

            $model->blog_thumb = $blog_thumb;

			$full_header=CUploadedFile::getInstance($model,'full_header');//added for image upload for full header Blog

			if (is_object($full_header) && get_class($full_header)==='CUploadedFile')

            $model->full_header = $full_header;

			if (is_object($model->blog_thumb))

			if (is_object($model->full_header))

			if($model->save())

			    $model->blog_thumb->saveAs(Yii::app()->basePath . '/../images/thumb/' . $model->blog_thumb->name);//added for image upload Blog

				$model->full_header->saveAs(Yii::app()->basePath . '/../images/full/' . $model->full_header->name);//added for image upload for full header Blog

				$this->redirect(array('view','id'=>$model->id));

				

		}


		$this->render('update',array(

			'model'=>$model,

		));

	}


	/**

	 * Deletes a particular model.

	 * If deletion is successful, the browser will be redirected to the 'index' page.

	 */

	public function actionDelete()

	{

		if(Yii::app()->request->isPostRequest)

		{

			// we only allow deletion via POST request

			$this->loadModel()->delete();


			// if AJAX request (triggered by deletion via admin grid view), we should not redirect the browser

			if(!isset($_GET['ajax']))

				$this->redirect(array('index'));

		}

		else

			throw new CHttpException(400,'Invalid request. Please do not repeat this request again.');

	}

 	/**

	 * Lists all models.

	 */

	public function actionIndex()

	{

		$criteria=new CDbCriteria(array(

			'condition'=>'status='.Post::STATUS_PUBLISHED,

			'order'=>'create_time DESC',

			'with'=>'commentCount',

		));

		if(isset($_GET['tag']))

			$criteria->addSearchCondition('tags',$_GET['tag']);


		$dataProvider=new CActiveDataProvider('Post', array(

			'pagination'=>array(

				'pageSize'=>Yii::app()->params['postsPerPage'],

			),

			'criteria'=>$criteria,

		));


		$this->render('index',array(

			'dataProvider'=>$dataProvider,

		));

	}


	/**

	 * Manages all models.

	 */

	public function actionAdmin()

	{

		$model=new Post('search');

		if(isset($_GET['Post']))

			$model->attributes=$_GET['Post'];

		$this->render('admin',array(

			'model'=>$model,

		));

	}


	/**

	 * Returns the data model based on the primary key given in the GET variable.

	 * If the data model is not found, an HTTP exception will be raised.

	 */

	public function loadModel()

	{

		if($this->_model===null)

		{

			if(isset($_GET['id']))

			{

				if(Yii::app()->user->isGuest)

					$condition='status='.Post::STATUS_PUBLISHED.' OR status='.Post::STATUS_ARCHIVED;

				else

					$condition='';

				$this->_model=Post::model()->findByPk($_GET['id'], $condition);

			}

			if($this->_model===null)

				throw new CHttpException(404,'The requested page does not exist.');

		}

		return $this->_model;

	}


	/**

	 * Creates a new comment.

	 * This method attempts to create a new comment based on the user input.

	 * If the comment is successfully created, the browser will be redirected

	 * to show the created comment.

	 * @param Post the post that the new comment belongs to

	 * @return Comment the comment instance

	 */

	protected function newComment($post)

	{

		$comment=new Comment;

		if(isset($_POST['ajax']) && $_POST['ajax']==='comment-form')

		{

			echo CActiveForm::validate($comment);

			Yii::app()->end();

		}

		if(isset($_POST['Comment']))

		{

			$comment->attributes=$_POST['Comment'];

			if($post->addComment($comment))

			{

				if($comment->status==Comment::STATUS_PENDING)

					Yii::app()->user->setFlash('commentSubmitted','Thank you for your comment. Your comment will be posted once it is approved.');

				$this->refresh();

			}

		}

		return $comment;

	}

}

my db for post


CREATE TABLE tbl_post

(

	id INTEGER NOT NULL PRIMARY KEY AUTO_INCREMENT,

	title VARCHAR(128) NOT NULL,

	blog_thumb VARCHAR(128) NOT NULL,

	full_header VARCHAR(128) NOT NULL,

	content TEXT NOT NULL,

	tags TEXT,

	status INTEGER NOT NULL,

	create_time INTEGER,

	update_time INTEGER,

	author_id INTEGER NOT NULL,

	CONSTRAINT FK_post_author FOREIGN KEY (author_id)

        REFERENCES tbl_user (id) ON DELETE CASCADE ON UPDATE RESTRICT

)

Well I don’t have time now to test your code.

But I see that you pout double curly braces in your tableName function. What for?


        public function tableName()

        {

                return '{{post}}';

        }



Plus, it doesn’t seem to match your real table name [font=“Courier New”]tbl_post[/font].

Edit:

Well I didn’t know about this notation… So I guess you have tablePrefix = ‘tbl_’.

:slight_smile: