Documentation (PHPDoc) mismatch

Archives Bug Discussions
1

createUpdateCounterCommand() method has wrong params description:

$counters CDbCriteria the query criteria

$criteria array counters to be updated (counter increments/decrements indexed by column names.)

Should be:

$counters array counters to be updated (counter increments/decrements indexed by column names.)

$criteria CDbCriteria the query criteria

I think it is wrong generated from PHPDoc (params order in PHPDoc description doesn’t match params order in function)


/**

	 * Creates an UPDATE command that increments/decrements certain columns.

	 * @param mixed the table schema ({@link CDbTableSchema}) or the table name (string).

------>	 * @param CDbCriteria the query criteria

------>	 * @param array counters to be updated (counter increments/decrements indexed by column names.)

	 * @return CDbCommand the created command

	 * @throws CException if no counter is specified

	 */

	public function createUpdateCounterCommand($table,$counters,$criteria)

Tried to post it in comments for this page - http://www.yiiframework.com/doc/api/CDbCommandBuilder but cannot create comment, because (i think) have no posts in forum.

2

Thanks.

3

О, надо же, я так старался, писал по-английски. А в диалог вступил русский девелопер Yii :)

4

:)