[mech7]

One more thing how to use the delete function? If just get the model instance and delete it will not be called.. and will not remove the descendants. Shouldnt it use the beforeDelete event?

Because if i change it too:

/**
	 * Deletes node and it's descendants.
	 * @return boolean whether the deletion is successful.
	 */
	public function  beforeDelete($event) {
        parent::beforeDelete($event);

		$owner=$this->getOwner();

		if($owner->getIsNewRecord())
			throw new CDbException(Yii::t('yiiext','The node cannot be deleted because it is new.'));
        
		$transaction=$owner->getDbConnection()->beginTransaction();

		try
		{
			$root=$this->hasManyRoots ? $owner->{$this->root} : null;

			if($owner->isLeaf())
				$result=$owner->delete();
			else
			{
				$condition=$this->left.'>='.$owner->{$this->left}.' AND '.
					$this->right.'<='.$owner->{$this->right};

				if($root!==null)
					$condition.=' AND '.$this->root.'='.$root;

				$result=$owner->deleteAll($condition)>0;
			}

			if($result)
			{
				$first=$owner->{$this->right}+1;
				$delta=$owner->{$this->left}-$owner->{$this->right}-1;
				$this->shiftLeftRight($first,$delta,$root);
				$transaction->commit();

				return true;
			}
		}
		catch(Exception $e)
		{
			$transaction->rollBack();
		}

		return false;
	}

It will work

[samdark]

Latest version supports both moving to the same root and moving to another root. moveBefore / moveAsFirst should work fine.

For structure like this:

R
  N1
   N2
    N3

You can't move N1 to N2 or N3.

What error have you got?

[mech7]

samdark, on 27 July 2010 - 03:14 AM, said:

Latest version supports both moving to the same root and moving to another root. moveBefore / moveAsFirst should work fine.

For structure like this:

R
  N1
   N2
    N3

You can't move N1 to N2 or N3.

What error have you got?

Ok yes i see now it works the naming confused me.. i though this method id only to move and existing child to the first position

But it would be nicer if a parent could turn into a child.. for example if I have a drag and drop tree it can go any direction

[mech7]

also.. if i try to do: $save = $model->moveAsFirst($root); it seems to corrupt my table putting left and right in the negative

[samdark]

Hmm. Could you provide some code + DB values (4—5 nodes) before and after moving to root? It will help.

[Extak]

How can i create root node, when many roots mode is off?

[Ben]

Yeah, some more examples would be great. In order to create a root node (guess I need one? Even in "single root" mode?), I tried:

$root = new Menu();
// $root->lft = 1;
// $root->rgt = 2;
// $root->level = 1;
$root->text = 'root';

$root->saveNode( false );

Both with the commented attributes set and unset. I feel this implementation detail should be hidden, I didn't even know if the counters start at zero or one until I read some comments in this thread, and maybe it is hidden and I don't have to care about it. Just still didn't find out.
In the end, this always throws an exception "Many roots mode is off". And since it's a new record and since I can't save the AR using CActiveRecord::save, I'm feeling kind of lost here.

In the end, I created the root node directly in the DB (lft:1, rgt:2, level: 1, root: null) and managed to insert a node using the following snippet of code:

$root = Menu::model()->roots()->find();

if ($root instanceof CActiveRecord)
{
  $help = new Menu();
  $help->text = 'Help';
  $appended = $help->appendTo( $root, false );
}

Maybe this helps others to get started.

Is there a chance to get some small code snippets for each of the provided API methods? For example it seems to me as if the saveNode method is useless in single root mode, but maybe I'm using it the wrong way.

[Ben]

Another quick snippet:

  protected function createDefaultMenuItems()
  {
    $root = Menu::model()->roots()->find();
    if (!$root instanceof CActiveRecord)
      return;

    $help = new Menu();
    $help->text = 'Help';
    $help->enabled = true;
    $appended = $help->appendTo( $root, false );

    $about = new Menu();
    $about->text = 'About';
    $about->enabled = true;
    $about->appendTo( $help, false );

    // --- test data - START --------------------------------------------------

    $extensions = new Menu();
    $extensions->text = 'Extensions';
    $extensions->enabled = true;
    $extensions->insertBefore( $help, false );

    $install = new Menu();
    $install->text = 'Install';
    $install->enabled = false;
    $install->appendTo( $extensions, false );

    $uninstall = new Menu();
    $uninstall->text = 'Uninstall';
    $uninstall->enabled = false;
    $uninstall->insertAfter( $install, false );

    $separator = new Menu();
    $separator->text = '-';
    $separator->enabled = false;
    $separator->insertAfter( $uninstall, false );

    $hasChildren = new Menu();
    $hasChildren->text = 'Has children';
    $hasChildren->enabled = true;
    $hasChildren->insertAfter( $separator, false );

    $child1 = new Menu();
    $child1->text = 'Child 1';
    $child1->enabled = false;
    $child1->appendTo( $hasChildren, false );

    $child2 = new Menu();
    $child2->text = 'Child 2';
    $child2->enabled = false;
    $child2->insertAfter( $child1, false );

    // --- test data - END --------------------------------------------------

  }

In words:

• Use "appendTo( parent, false )" for the first child you add to a parent
  
• Use "insertAfter( sibling, false )" for subsequent children you want to add to a group

I tried to build up my groups using:

$child1->appendTo( $parent, false );
$child2->appendTo( $parent, false );

before, but every appendTo inserted the item as first child of parent which wasn't what I'd expected.

[hk1]

I'm trying to understand what values are stored in the 'root' field and the 'level' field. I wouldn't need to know this except that I'm building a backoffice administration app that we'll most likely use to configure our categories. I want to make sure I use the correct logic so that this extension will work if and when I want to use it.

[samdark]

Here is the test that will probably help you: http://code.google.c...ehaviorTest.php

Also there is an article: http://en.wikipedia....ested_set_model

[szako]

Hey

First of all, Thank you for implementing nested tree!

I'm facing a problem atm. The situation:

I'm making a webshop with nested categories, using the nested tree. When someone deletes a category, the program seeks for products assigned to that category and its subcategories, if found, the category must be not deleted. So I run the event beforeDelete. This works like a charm when the category is a leaf, but when it has subcategories the event doesn't get raised because of deleteAll() used in nestedtree's delete() method.

I think I will manually raise the event in the controller before deleting (if the category is not a leaf) and lean on the event's return. What do you think? Anyone had a similar case?

[samdark]

Manually raising event is the proper solution. At least for now.

[szako]

Hey samdark, thanks for the reply!

The thing is done, tho I had to modify the extension.
I had to implement a new method into it:

        public function setIgnoreEvent($ignoreEvent)
        {
            $this->_ignoreEvent=$ignoreEvent;
        }

I did this because in the behavior beforeDelete() method checks for _ignoreEvent and if it is false, the event raising stops. What do you think? I think you should include this into the class.

So the code looks like:

                $toDelete = true;
                $category->tree->setIgnoreEvent(true);
                if (!$category->beforeDelete()) {
                    $toDelete = false;
                }
                $category->tree->setIgnoreEvent(false);

                if ($toDelete && $category->tree->deleteNode()) {
                    $this->messages[] = 'Sikeresen letöröltem a kategóriát.';
                } else {
                    $this->messages['hasError'] = 1;
                    $this->messages[] = 'Nem tudtam letörölni a kategóriát!';
                    foreach ($category->getErrors() as $field => $error) {
                        $this->messages[] = $error[0];
                    }
                }

[samdark]

Maybe using the following will be less hacky:

if(!$node->isLeaf)
{
    foreach($node->descendants() as $d)
        if($d->thereAreProducts())
            break;
}

[szako]

I put the checking into one method:

        public function categoryHasProducts($mainCat)
        {            
            $command = Yii::app()->db->createCommand()
                        ->select('COUNT(id)')
                        ->from('{{product_mobiltelefon}}');
            
            if ($mainCat->isLeaf()) {    
                $command->where('category_id = '.$mainCat->id);
            } else {
                $subCategories = $mainCat->descendants()->findAll(array('index' => 'id', 'select' => 'id'));
                $command->where('category_id IN ('.implode(',', array_merge(array($mainCat->id), array_keys($subCategories))).')');
            }
            
            return $command->queryScalar();
        }

So I have to call it only once on the category. No problem, I'm gonna put the method into the new nestedtree releases as well.

Thanks!

[samdark]

Probably it's better to put it into the model itself if it's used from controller.

[szako]

It is already in the (product) model. The event handler calls it:

        public static function handleProductCategoryDelete(&$event)
        {
            $productCount = self::categoryHasProducts($event->sender);

            if ((int)$productCount > 0) {
                $event->message = "A kategória tartalmaz {$productCount} db terméket, ezeket le kell először törölni.";
            }
        }

[WallTearer]

Hey, thanks for the ext, it's very usefull, especially with ENestedSetBehavior2 improvement, that is suggested in comments to nestedsetbehavior extension page.

But I'd like to ask you, if there is any chance that you will add the support for `parent_id` field? Or I'll (and other people who we'll need it) have to add it manualy?
Thanks.

[samdark]

Well, parent_id isn't really nested set related so don't know if it should be included.

[WallTearer]

Meanwhile, I solved this problem by extending model in this way:

<?php
class Communicate extends CActiveRecord
{
    // Will be storing parent id here
    public $parent_id;

    /**
     * Communicate with id of its parent.
     * Id of parent will be stored in ->parent_id
     */
    public function withParent()
    {
        $owner=$this->getOwner();
        $db=$owner->getDbConnection();
        $criteria = $owner->getDbCriteria();

        $criteria->select .= ', `parent`.ID as `parent_id`';

        $select =
            ' SELECT * from ' . $db->quoteColumnName($owner->tableName()) .
            ' WHERE ' . $db->quoteColumnName($owner->tableName()) . '.ROOT = ' . $this->ROOT .
            ' ORDER BY ' . $db->quoteColumnName($owner->tableName()) . '.LFT DESC';

        $criteria->join .= 
            'LEFT JOIN ('.$select.') `parent` ' .
            'ON (`parent`.LFT < `t`.LFT AND `parent`.RGT > `t`.RGT)'; 

        $criteria->group = '`t`.ID';

        return $owner;
    }

    /**
     * Need to populate extended data
     */
    public function populateRecord($attributes,$callAfterFind=true)
    {
        $record = parent::populateRecord($attributes, $callAfterFind);

        if ( $record )
        {
            //getting parent id if it's set
            if ( isset($attributes['parent_id']) )
                $record->parent_id = $attributes['parent_id'];
        }

        return $record;
    }

}

// And I'm triggering this like:
Communicate::model()->withParent()->findAll();

Maybe this will help somebody, cause getting parent ids of more than one item is not trivial.
Possibly, it's not the best solution, but works for me.

Anyway, thanks a lot for this extension, saved a lot of time.